Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove date conversion #2398

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Remove date conversion #2398

merged 4 commits into from
Jan 6, 2025

Conversation

jzbahrai
Copy link
Collaborator

@jzbahrai jzbahrai commented Dec 19, 2024 •
edited
Loading

Summary | Résumé

For this func:

  1. We were taking today's UTC and converting it to midnight in a given timezone, we they were converting it back to UTC.
  2. We changed the callers and the actual function to fix this

Related Issues | Cartes liées

https://app.zenhub.com/workspaces/notify-planning-614b3ad91bc2030015ed22f5/issues/gh/cds-snc/notification-planning/1717

Testing:

  • Test things locally by setting up this PR on localhost

whabanks
whabanks approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@whabanks whabanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzbahrai jzbahrai merged commit 5f64494 into main Jan 6, 2025
5 checks passed
@jzbahrai jzbahrai deleted the task/fix-calculations branch January 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whabanks whabanks whabanks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzbahrai @whabanks